Fix for vulkan sysgpu backend when only some attachments are cleared#1339
Open
platypro wants to merge 3 commits intohexops:mainfrom
Open
Fix for vulkan sysgpu backend when only some attachments are cleared#1339platypro wants to merge 3 commits intohexops:mainfrom
platypro wants to merge 3 commits intohexops:mainfrom
Conversation
Signed-off-by: Aeden McClain <dev@platypro.net>
Member
|
Thanks for sending this, I need to check if this alters the behavior of any examples we have - not sure the underlying intention of this logic before |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue I ran into when I tried to "load" a color attachment, but "clear" the depth attachment. I got a validation error saying that all buffers must be represented in p_clear_values/clear_value_count so the driver can just jump to find the matching attachment.