glfw: update build script to use latest zig build API#704
Closed
Avokadoen wants to merge 1 commit intohexops:mainfrom
Closed
glfw: update build script to use latest zig build API#704Avokadoen wants to merge 1 commit intohexops:mainfrom
Avokadoen wants to merge 1 commit intohexops:mainfrom
Conversation
Contributor
Avokadoen
commented
Feb 7, 2023
Avokadoen
commented
- By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.
Contributor
Author
|
This PR is missing changes to the |
alichraghi
reviewed
Feb 8, 2023
|
|
||
| pub const BuildError = error{CannotEnsureDependency} || std.mem.Allocator.Error; | ||
| fn buildLibrary(b: *Builder, mode: std.builtin.Mode, target: std.zig.CrossTarget, options: Options) BuildError!*std.build.LibExeObjStep { | ||
| pub const Buildror = error{CannotEnsureDependency} || std.mem.Allocator.Error; |
Contributor
Author
There was a problem hiding this comment.
I honestly have no idea how I managed to do that 😭 😆
1 task
Member
|
Thanks for sending! I've gone ahead and merged this and the other open PR into a branch: #706 Once I address a few other updates I will merge this as part of that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.