feat(skills): pre-plan persistent-subject choreography (Addition C)#451
Open
vanceingalls wants to merge 1 commit intovance/skill-content-culture-real-subjectfrom
Open
Conversation
User feedback from eval 5 exposed a real R4 failure mode: - p2 Thread: Maya's card persisted across scenes (good) but often landed in positions that didn't fit the scene's content hierarchy (bad). Semantic-mismatch. - p3 Vermeer: painting zoomed to 2.1x in scene 2, blocking the right-column metadata the scene subagent had authored. Size- collision. Root cause: expansion identifies the subject, scene subagents author their scenes INDEPENDENTLY (picking their own layouts), and the scaffold tweens the subject's position/scale across transitions as an afterthought. Scene subagents don't know how big the subject will be in THEIR scene, so they place their chrome wherever, and then the scaffold's tween scales the subject up or moves it into regions already filled. Fix: expansion pre-plans the choreography BEFORE the per-scene detailed breakdown. Per-scene block specifies: - position (center x, y) - scale - size_envelope (actual on-screen footprint in this scene) - role (focal / background anchor / data-point / glyph-slot / ...) - reserved_region (rectangle scene subagent must leave empty) - scene_must_avoid (short instruction) Orchestrator (multi-scene.md) passes each scene subagent its scene's choreography block plus the contract: - The scaffold owns the subject's DOM + timeline. - Your scene layout MUST respect the reserved region. - Design your scene chrome around the element's role in this scene. - Do NOT animate the persistent subject in your timeline. Invariants: - Size envelope reflects the SETTLED state (if the subject scales up during the scene, reserve for the larger size). - Scene-to-scene positions trace a visually-coherent path, not leapfrogs. - Role changes drive reserved-region size. Branch worktree only. Not synced to installed main skill path.
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Brief description of the change.
Why
Why is this change needed?
How
How was this implemented? Any notable design decisions?
Test plan
How was this tested?