Add ROG Laptop support, with initial GA403 support#284
Open
daegalus wants to merge 1 commit intohhd-dev:masterfrom
Open
Add ROG Laptop support, with initial GA403 support#284daegalus wants to merge 1 commit intohhd-dev:masterfrom
daegalus wants to merge 1 commit intohhd-dev:masterfrom
Conversation
Contributor
|
Can you do a split PR for tdp? In addition, it would be nice for tdp if you tried to make it laptop generic without a custom tdp slider The current Asus driver will work fine with laptops if you add all of the custom values for your model |
Contributor
|
As for the rgb stuff, can you lower the number of changes? Especially when it comes to logging. You don't need a separate method to do feature reports. If you tell me that in your laptop sending feature reports works instead output reports then it's fine to change it universally to send feature reports I will repro on my Z13 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@antheas asked if I could attempt adding support for my ROG laptop to HHD.
After much toil, I have keyboard lighting, slash lightbar configuration, fan curve support, and power profiles supported now.
I had to modify Aura device a bit as i needed different modes of communication with the devices. I made it configureable and flexible.
Test device: Asus ROG Zephyrus G14 (2024) model, GA403UI.
Please let me know if you want me to move anything around, formatting changes, etc.
AI Disclaimer: I used AI to help me discover settings values, USB/HID/Report/Etc variations, and cleanup the code after my copy, paste, edit loop had created a nice frankenstein from the ally code. I don't do a lot of python daily anymore, nor much hardware work.
Screenshots: