HH-123895 increase request timeout #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzharikhin
reviewed
Feb 9, 2021
consul/aio.py
Outdated
| connector = aiohttp.TCPConnector(loop=self._loop, | ||
| verify_ssl=self.verify) | ||
| async with aiohttp.ClientSession(connector=connector) as session: | ||
| async with aiohttp.ClientSession(connector=connector, timeout=ClientTimeout(total=800)) as session: |
There was a problem hiding this comment.
это должно конфигуриться.
и нужна логика, чтобы нельзя было вызвать в неправильном сочетании параметров с watch
heruv1m
reviewed
Feb 10, 2021
consul/base.py
Outdated
| assert total_timeout, \ | ||
| 'total_timeout should be setter' | ||
| assert not self._convert_wait_to_seconds(wait) >= total_timeout, \ | ||
| 'wait should be less than total_timeout' |
There was a problem hiding this comment.
можно цифры еще добавить. Так легче ошибку будет искать
dzharikhin
reviewed
Feb 10, 2021
consul/base.py
Outdated
| params.append(('index', index)) | ||
| if wait: | ||
| assert total_timeout, \ | ||
| 'total_timeout should be setter' |
There was a problem hiding this comment.
Suggested change
| 'total_timeout should be setter' | |
| 'total_timeout should be setted' |
heruv1m
approved these changes
Feb 10, 2021
nicholasgribanov
force-pushed
the
HH-123895
branch
from
722f348 to
a71a597
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.