Skip to content
This repository was archived by the owner on Aug 25, 2025. It is now read-only.

Conversation

@Atry
Copy link
Contributor

@Atry Atry commented Jun 6, 2022

No description provided.

Copy link
Contributor

@lexidor lexidor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

};

class HackBuilderNativeValueCollectionRenderer<Tv, T as Traversable<Tv>>
final class HackBuilderNativeValueCollectionRenderer<Tv, T as Traversable<Tv>>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't consider it likely, but soneone could have extended this class. They couldn't override render() anyway, so sealing this class is fine.

@lexidor
Copy link
Contributor

lexidor commented Jun 6, 2022

Unexpected file extension (probably not a Hack file): /tmp/hack-codegen-hackfmt7qvPSP

Hackfmt was recently changed.

@Atry
Copy link
Contributor Author

Atry commented Jun 6, 2022

See #150

@Atry Atry merged commit 8a67f08 into hhvm:main Jun 6, 2022
@Atry Atry deleted the lint-errors branch June 6, 2022 18:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants