Fix regexp: Match A-Z, not A-z #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regexp is otherwise overmatching, ASCII (and UTF) has many characters between Z and a which are currently also matched: ^ and _ for example.
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
=======================================
Coverage 99.72% 99.72%
=======================================
Files 6 6
Lines 364 364
=======================================
Hits 363 363
Misses 1 1
Continue to review full report at Codecov.
|
Owner
|
👍 Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regexp is otherwise overmatching, ASCII (and UTF) has many characters between Z and a which are currently also matched: ^ and _ for example.