added exporting.csv.url option#12
added exporting.csv.url option#12raveren wants to merge 3 commits intohighcharts:masterfrom raveren:master
Conversation
There was a problem hiding this comment.
style question -- would it be better to explicitly pass false as the parameter, rather than relying on the fact that unpassed parameters default to undefined, which is evaluated as false?
There was a problem hiding this comment.
Not really sure, since JS does not offer default parameter values by default, I usually go this way, but it's just a question of consistency in the whole codebase actually (which I admit didn't check).
|
Sorry, that last comment was from me, not @enggine. Also, do I correctly understand a second feature of this PR, aside from permitting the url to be set, is the ability to call getCSV() on a Chart and then directly get the csv data, which one could then do something else with in javascript? |
|
Correct, but this was the functionality before my changes so I made effort to keep it that way. |
|
Ah @raveren I see now, thanks. |
* y-values for same x-values from different series are placed in same row * x-values no longer duplicated as columns for each series * X column title and downloaded file title is taken from user provided values when configuring the chart if available. * Browser-side download is used if supported by browser bypassing server-side script * Default title of chart is passed to backend along with csv string. known issues: multiple x axes (no longer?) supported
|
Ok, that is not what I intended, I wanted a separate pull request, as the two latter commits introduce potentially breaking changes which I only tested in my own production setting. It used to generate CSV with x-axes repeated as many times as there were series, which is illogical:
so I set out to fix it, please let me know what you think and whether I can improve anything not to your liking. |
|
1+ |
|
This one can be closed since #40 has been merged. |
6 participants
no more privacy concerns and
https://raw.github.com/highslide-software/highcharts.com/master/studies/csv-export/csv.php
says