Skip to content

Make userOptions of the chart available within customCode context #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PaulDalek merged 5 commits into from
Aug 5, 2024
Merged

Make userOptions of the chart available within customCode context #551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
57787f4
Make userOptions of the chart available within customCode context
level420 Jul 31, 2024
32bca05
Merge branch 'highcharts:master' into fix-issue-548-options-in-custom…
level420 Aug 2, 2024
7be35f4
Update CHANGELOG.md
level420 Aug 2, 2024
7f235d0
Merge branch 'master' into fix-issue-548-options-in-customcode-context
level420 Aug 5, 2024
ca80ae0
Update CHANGELOG.md
PaulDalek Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
# 4.0.2

_Fixes:_

- Made chart userOptions available within `customCode` as variable `options` [(#551)](https://github.com/highcharts/node-export-server/issues/551).

# 4.0.1

_Hotfix_:
Expand Down
10 changes: 5 additions & 5 deletions lib/highcharts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,6 @@ export async function triggerExport(chartOptions, options, displayErrors) {
// prevent from polluting other exports that can happen on the same page
Highcharts.setOptionsObj = merge(false, {}, getOptions());

// Trigger custom code
if (options.customLogic.customCode) {
new Function(options.customLogic.customCode)();
}

// By default animation is disabled
const chart = {
animation: false
Expand Down Expand Up @@ -100,6 +95,11 @@ export async function triggerExport(chartOptions, options, displayErrors) {
const userOptions = options.export.strInj
? new Function(`return ${options.export.strInj}`)()
: chartOptions;

// Trigger custom code
if (options.customLogic.customCode) {
new Function('options', options.customLogic.customCode)(userOptions);
}

// Merge the globalOptions, themeOptions, options from the wrapped
// setOptions function and user options to create the final options object
Expand Down