Skip to content

fix: upgrade Python version and OpenTelemetry dependencies#191

Merged
dhruvj07 merged 2 commits intomainfrom
upgrade-python-otel-deps
May 7, 2025
Merged

fix: upgrade Python version and OpenTelemetry dependencies#191
dhruvj07 merged 2 commits intomainfrom
upgrade-python-otel-deps

Conversation

@ankumar
Copy link
Copy Markdown
Contributor

@ankumar ankumar commented May 5, 2025

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ankumar, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request updates the project's Python version and several dependencies. Specifically, it upgrades the Python version from 3.8 to 3.9 and updates various OpenTelemetry libraries, httpx, pytest, and mkdocs-material. The changes are primarily focused on the pyproject.toml file.

Highlights

  • Python Version Upgrade: The Python version has been upgraded from 3.8 to 3.9 in pyproject.toml.
  • OpenTelemetry Dependencies: OpenTelemetry dependencies have been updated to newer versions, including opentelemetry-api, opentelemetry-sdk, opentelemetry-exporter-otlp-proto-http, and opentelemetry-semantic-conventions.
  • Testing Dependencies: Testing dependencies such as pytest and pytest-httpx have been updated to newer versions.
  • Documentation Dependencies: The mkdocs-material dependency has been updated to a newer version.

Changelog

  • pyproject.toml
    • Upgraded Python version from 3.8 to 3.9 (line 18).
    • Updated httpx dependency from 0.24.0 to 0.27.2 (line 19).
    • Updated OpenTelemetry dependencies to newer versions (lines 26-30).
    • Updated pytest dependency from 7.3.1 to 8.3.5 (line 39).
    • Updated pytest-httpx dependency from 0.22.0 to 0.32.0 (line 40).
    • Updated mkdocs-material dependency from 9.1.13 to 9.6.11 (line 52).
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


A version bump,
Dependencies jump,
Code evolves fast,
Bugs are things of the past,
Tests ensure it will last.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the Python version and various dependency versions including OpenTelemetry and testing libraries to support new features and improved performance.

  • Upgrade Python from 3.8 to 3.9
  • Update httpx, OpenTelemetry, and related packages to newer versions
  • Upgrade test dependencies and mkdocs-material version

Comment thread pyproject.toml
Comment on lines +32 to +36
# opentelemetry-instrumentation = "^0.53b1"
# opentelemetry-instrumentation-botocore = "^0.53b1"
# opentelemetry-util-http = "^0.53b1"
# opentelemetry-instrumentation-asgi = "^0.53b1"
# opentelemetry-instrumentation-fastapi = "^0.53b1"
Copy link

Copilot AI May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider removing the commented out OpenTelemetry instrumentation dependencies or including a brief explanation for why they remain commented out to improve clarity and maintainability.

Suggested change
# opentelemetry-instrumentation = "^0.53b1"
# opentelemetry-instrumentation-botocore = "^0.53b1"
# opentelemetry-util-http = "^0.53b1"
# opentelemetry-instrumentation-asgi = "^0.53b1"
# opentelemetry-instrumentation-fastapi = "^0.53b1"
# opentelemetry-instrumentation = "^0.53b1" # Commented out: These dependencies are optional and can be included if instrumentation for specific frameworks or libraries is required.
# opentelemetry-instrumentation-botocore = "^0.53b1" # Commented out: Add if using Botocore instrumentation.
# opentelemetry-util-http = "^0.53b1" # Commented out: Add if using HTTP utility instrumentation.
# opentelemetry-instrumentation-asgi = "^0.53b1" # Commented out: Add if using ASGI framework instrumentation.
# opentelemetry-instrumentation-fastapi = "^0.53b1" # Commented out: Add if using FastAPI framework instrumentation.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates the Python version and OpenTelemetry dependencies. The changes seem straightforward and necessary for keeping the project up-to-date and secure. However, I have a few observations regarding the dependency updates and some minor suggestions.

Summary of Findings

  • OpenTelemetry Instrumentation Dependencies: The pull request comments out several OpenTelemetry instrumentation dependencies. It would be helpful to understand the reasoning behind this change, and whether these dependencies are intended to be removed or temporarily disabled.
  • Python Version Update: The update of the Python version from 3.8 to 3.9 is a significant change. It's important to ensure that all dependencies are compatible with Python 3.9 and that any necessary code adjustments have been made.

Merge Readiness

The pull request appears to be a routine update of dependencies. However, the commented-out OpenTelemetry instrumentation dependencies warrant further investigation. I recommend confirming the intention behind these changes before merging. I am unable to approve this pull request, and users should have others review and approve this code before merging. Given the medium severity comment, I would recommend that the pull request not be merged until those are addressed (at a minimum).

@dhruvj07 dhruvj07 merged commit d038ba6 into main May 7, 2025
5 of 6 checks passed
@ankumar ankumar deleted the upgrade-python-otel-deps branch June 3, 2025 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants