Skip to content

fix: updated west region to east-1 for bedrock client #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dhruvj07 merged 1 commit into from
May 6, 2025
Merged

fix: updated west region to east-1 for bedrock client #192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/bedrock/bedrock_client_universal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ def init_bedrock():
3) Return the bedrock_runtime_client for direct 'invoke_model' calls.
"""
bedrock_runtime_client = boto3.client(
service_name="bedrock-runtime", region_name="us-west-2"
service_name="bedrock-runtime", region_name="us-east-1"
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Is us-east-1 the correct region for all use cases? It might be helpful to add a comment explaining why this region was chosen and whether it should be configurable via an environment variable or other configuration means. This would increase the flexibility of the code.

        service_name="bedrock-runtime", region_name="us-east-1"  # Updated to us-east-1. Consider making this configurable via environment variable

)
bedrock_client = boto3.client(service_name="bedrock", region_name="us-west-2")
bedrock_client = boto3.client(service_name="bedrock", region_name="us-east-1")
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Same as above, is us-east-1 the correct region for all use cases? It might be helpful to add a comment explaining why this region was chosen and whether it should be configurable via an environment variable or other configuration means. This would increase the flexibility of the code.

    bedrock_client = boto3.client(service_name="bedrock", region_name="us-east-1")  # Updated to us-east-1. Consider making this configurable via environment variable


config = JavelinConfig(
javelin_api_key=os.getenv("JAVELIN_API_KEY") # Replace with your Javelin API key
Expand Down
Loading