fix: update route models

[abhijitjavelin]

No description provided.

[gemini-code-assist]

Hello @abhijitjavelin, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

Hello team, gemini-code-assist here to provide a summary of this pull request. This PR primarily focuses on updating the data models within the Javelin SDK, specifically restructuring the RouteConfig model for better organization and introducing new concepts like Policy and ArchivePolicy as nested models. Additionally, it adds a new SecretType enum and includes a minor fix in the client to ensure a default route name is used when registering bedrock if none is provided.

Highlights

• Route Model Restructuring: The RouteConfig model in javelin_sdk/models.py has been significantly refactored. Several fields related to policies (like dlp, content_filter, prompt_safety, security_filters, archive, retention) have been removed from the top level of RouteConfig.
• Introduction of Policy Models: New nested models ArchivePolicy and Policy have been introduced in javelin_sdk/models.py. ArchivePolicy holds archiving configuration (enabled, retention), and Policy aggregates various policy configurations (dlp, archive, enabled, prompt_safety, content_filter, security_filters). The RouteConfig model now includes a policy field referencing the new Policy model.
• New Fields in RouteConfig: The RouteConfig model now includes fields for budget and unified_endpoint.
• New SecretType Enum: A new SecretType enum has been added to javelin_sdk/models.py with values 'aws' and 'kubernetes'.
• Default Bedrock Route Name: The register_bedrock function in javelin_sdk/client.py now defaults the route_name to 'awsbedrock' if no route name is explicitly provided.

Changelog

• javelin_sdk/client.py
  • Added a check to default the route_name to 'awsbedrock' in register_bedrock if it's not provided.
• javelin_sdk/models.py
  • Restructured the RouteConfig model, moving policy-related fields into a nested Policy model.
  • Introduced new ArchivePolicy and Policy BaseModel classes.
  • Added budget and unified_endpoint fields to RouteConfig.
  • Added a new SecretType enum with 'aws' and 'kubernetes' values.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

Models shift and change,
Data structures rearrange,
Code evolves anew.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates route models by refactoring RouteConfig, introducing ArchivePolicy and Policy for better organization, and adding a SecretType enum. Additionally, a default route name for Bedrock registration has been added in client.py.

The refactoring in models.py improves modularity, which is a positive step. However, there are some concerns regarding fields removed from RouteConfig that need clarification. The pull request description is currently empty; adding details about these changes, especially the rationale for removing fields, would greatly improve the reviewability and understanding of this PR.

Summary of Findings

• Missing PR Description: The PR lacks a description detailing the significant model changes, especially the removal of several fields from RouteConfig. This makes it hard to understand the intent and impact of the changes.
• Potential Breaking Changes in RouteConfig: Several fields (owner, organization, llm_cache, role_to_assume, enable_telemetry) have been removed from RouteConfig. Clarification is needed on whether this is intentional, and if so, the rationale and impact. This is flagged as a high-severity concern.
• Clarity of Policy.enabled Flag: The purpose and interaction of the enabled flag within the Policy model could be clearer regarding its effect on sub-policies. This is flagged as a medium-severity concern.
• Magic String for Default Bedrock Route (Low Severity): In javelin_sdk/client.py, the string 'awsbedrock' is used as a default route name. For better maintainability, consider defining this as a constant. (Not commented directly due to review settings).
• Potentially Unused SecretType Enum (Low Severity): The new SecretType enum is defined in javelin_sdk/models.py but doesn't appear to be used within the Secret model or other parts of models.py changed in this PR. This is acceptable if it's for future use or used elsewhere. (Not commented directly due to review settings).

Merge Readiness

This pull request introduces some beneficial refactoring to the route models. However, due to the high-severity concern regarding the unexplained removal of several fields from RouteConfig and the lack of a PR description, I recommend that these changes not be merged until these points are addressed. Clarifying the intent behind the RouteConfig modifications is crucial to ensure no functionality is unintentionally lost or broken. I am unable to approve this pull request; please ensure further review and approval from other team members after addressing the feedback.