fix: lint issues

[abhijitjavelin]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @abhijitjavelin, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on enhancing the overall code quality and maintainability of the javelin_cli and javelin_sdk components. It addresses various linting issues, refactors core functionalities for better readability and type safety, and improves the robustness of OpenTelemetry tracing for AI-related operations. The changes also include updates to Pydantic models to align with best practices for data structure definition.

Highlights

• Linting and Code Cleanup: Removed numerous unused imports (e.g., os, trace, List, various exceptions) and unused variables (result) across javelin_cli and javelin_sdk modules, improving code cleanliness and reducing bundle size.
• Improved Type Hinting and Pydantic Models: Extensively updated type hints, especially using Optional for Pydantic model fields and Union for return types to support streaming. Pydantic models now use default_factory=list for list fields, preventing mutable default argument issues and enhancing data handling flexibility.
• Refactoring of Service Methods: Converted all lambda function definitions for client service methods (e.g., gateway, provider, route, secret, template) into standard def methods. This significantly improves readability, debuggability, and allows for more robust type hinting.
• Enhanced OpenTelemetry Tracing: Made significant improvements to OpenTelemetry span capturing in javelin_sdk/client.py, including more robust handling of streaming responses, better attribute setting for AI operations, and explicit checks for None values to prevent errors.
• Robust Async/Sync Request Handling: Refined _send_request_sync and _send_request_async in javelin_sdk/client.py to explicitly check and enforce expected return types, preventing unexpected behavior in mixed asynchronous and synchronous contexts.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This PR provides a good set of linting fixes and refactorings that improve code quality and correctness. The changes from lambdas to proper methods and the improved type hints are particularly valuable. I've noted a few issues, including a high-severity bug in URL construction, some leftover debugging code, and minor opportunities for efficiency and clarity improvements. Addressing these points will further strengthen the SDK.