Skip to content

Remove nil values from data object in create methods.#207

Merged
abhijitjavelin merged 6 commits intomainfrom
update_makefile
Jul 16, 2025
Merged

Remove nil values from data object in create methods.#207
abhijitjavelin merged 6 commits intomainfrom
update_makefile

Conversation

@abhijitjavelin
Copy link
Copy Markdown
Contributor

`{

"regex": null, // removes this

}`

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @abhijitjavelin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on improving the data serialization process for API requests by preventing None values from being sent in data objects. Concurrently, it updates the project's development dependencies and build commands to migrate from ruff and mypy to flake8 for code linting, simplifying the local development setup.

Highlights

  • Data Serialization Refinement: Modified various create and update methods across several service files (gateway_service.py, provider_service.py, route_service.py, secret_service.py, template_service.py) to use exclude_none=True when converting Pydantic models to dictionaries for API requests. This ensures that fields with None values are not included in the outgoing request payloads, leading to cleaner and potentially more robust API interactions.
  • Development Tooling Update: The project's Makefile and pyproject.toml have been updated to replace ruff and mypy with flake8 for code linting. This change streamlines the development environment's quality checks by consolidating linting under a single tool.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements the removal of null values from API request payloads by using exclude_none=True when serializing Pydantic models. The changes are consistently applied to create and update methods across all relevant services. Additionally, the pull request includes changes to the project's development tooling, specifically the removal of the ruff linter.

Comment thread Makefile
Comment thread javelin_sdk/services/gateway_service.py
Comment thread javelin_sdk/services/gateway_service.py
Comment thread javelin_sdk/services/provider_service.py
Comment thread javelin_sdk/services/provider_service.py
Comment thread javelin_sdk/services/secret_service.py
Comment thread javelin_sdk/services/template_service.py
Comment thread javelin_sdk/services/template_service.py
Comment thread javelin_sdk/services/template_service.py
Comment thread javelin_sdk/services/template_service.py
@abhijitjavelin abhijitjavelin merged commit 41f3921 into main Jul 16, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants