In-memory prototype of MARF replace (SOAR-DB!)#213
Merged
Conversation
jbencin
approved these changes
Feb 14, 2023
Contributor
jbencin
left a comment
jbencin
left a comment
There was a problem hiding this comment.
Overall very nice code! I've only got a couple minor comments:
- It seems like a lot of dependencies are declared in
Cargo.tomlbut not used - I'd recommend putting
//!comments at the top of each file, it makes navigating documentation easier
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #213 +/- ##
==========================================
+ Coverage 91.19% 92.04% +0.85%
==========================================
Files 6 6
Lines 284 327 +43
==========================================
+ Hits 259 301 +42
- Misses 25 26 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
Author
|
Thanks for the review! I eliminated the unused dependencies (which aren't getting used in a subsequent PR) and also added rustdoc inline ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements an in-memory optimistic fork-aware data store, for replacing the MARF. The general idea with the datastore is to store the current data view as a normal key-value store and track the history of operations on the storage. When a fork occurs, the data state is unwound and then replayed.
This first PR just implements and tests a simple in-memory version of the data store, which unblocks work on integrating the db with the rest of the subnet node (that work is ongoing in the
feat/soar-dbbranch.