Skip to content

feat: add events for ft/nft registrations#215

Merged
obycode merged 1 commit intomasterfrom
feat/register-events
Feb 21, 2023
Merged

feat: add events for ft/nft registrations#215
obycode merged 1 commit intomasterfrom
feat/register-events

Conversation

@obycode
Copy link
Copy Markdown
Contributor

@obycode obycode commented Feb 16, 2023

        (print {
            event: "register-contract",
            asset-type: "nft",
            l1-contract: (contract-of nft-contract),
            l2-contract: l2-contract
        })

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 16, 2023

Codecov Report

Merging #215 (9d1e200) into master (54c653c) will increase coverage by 1.08%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #215      +/-   ##
==========================================
+ Coverage   91.19%   92.28%   +1.08%     
==========================================
  Files           6        6              
  Lines         284      337      +53     
==========================================
+ Hits          259      311      +52     
- Misses         25       26       +1     
Impacted Files Coverage Δ
core-contracts/contracts/helper/simple-ft.clar 76.47% <ø> (ø)
...contracts/contracts/helper/simple-nft-no-mint.clar 66.66% <ø> (ø)
core-contracts/contracts/helper/simple-nft.clar 73.33% <ø> (ø)
core-contracts/contracts/multi-miner.clar 97.05% <ø> (ø)
core-contracts/contracts/subnet.clar 94.96% <ø> (+0.81%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@obycode obycode force-pushed the mint-with-trait branch 2 times, most recently from 2e40b5d to 4a629c5 Compare February 19, 2023 00:24
Base automatically changed from mint-with-trait to master February 19, 2023 01:44
```
        (print {
            event: "register-contract",
            asset-type: "nft",
            l1-contract: (contract-of nft-contract),
            l2-contract: l2-contract
        })
```
@obycode obycode force-pushed the feat/register-events branch from c9c29be to 9d1e200 Compare February 21, 2023 13:10
@obycode obycode requested review from jbencin and kantai February 21, 2023 13:11
Copy link
Copy Markdown
Contributor

@kantai kantai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@obycode obycode merged commit 2ccc460 into master Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants