Skip to content

fix: use bullseye instead of alpine for docker image#220

Merged
obycode merged 1 commit intomasterfrom
docker-bullseye
Feb 27, 2023
Merged

fix: use bullseye instead of alpine for docker image#220
obycode merged 1 commit intomasterfrom
docker-bullseye

Conversation

@obycode
Copy link
Copy Markdown
Contributor

@obycode obycode commented Feb 24, 2023

For some reason, the docker image does not work when based on alpine.

@obycode obycode requested a review from kantai February 24, 2023 03:14
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 24, 2023

Codecov Report

Merging #220 (7c9ecb7) into master (048c71e) will increase coverage by 92.26%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           master     #220       +/-   ##
===========================================
+ Coverage        0   92.26%   +92.26%     
===========================================
  Files           0        6        +6     
  Lines           0      336      +336     
===========================================
+ Hits            0      310      +310     
- Misses          0       26       +26     
Impacted Files Coverage Δ
core-contracts/contracts/helper/simple-nft.clar 73.33% <0.00%> (ø)
core-contracts/contracts/helper/test-helpers.clar 100.00% <0.00%> (ø)
core-contracts/contracts/multi-miner.clar 97.05% <0.00%> (ø)
core-contracts/contracts/helper/simple-ft.clar 75.00% <0.00%> (ø)
...contracts/contracts/helper/simple-nft-no-mint.clar 66.66% <0.00%> (ø)
core-contracts/contracts/subnet.clar 94.96% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

For some reason, the docker image does not work when based on alpine.
Copy link
Copy Markdown
Contributor

@kantai kantai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alpine -> debian sounds good to me

@obycode obycode merged commit 1de11ff into master Feb 27, 2023
@obycode obycode deleted the docker-bullseye branch February 27, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants