Skip to content

Fix errors in Deno VSCode extension#223

Merged
jbencin merged 1 commit intohirosystems:masterfrom
jbencin:fix/deno-vscode-extension
Mar 1, 2023
Merged

Fix errors in Deno VSCode extension#223
jbencin merged 1 commit intohirosystems:masterfrom
jbencin:fix/deno-vscode-extension

Conversation

@jbencin
Copy link
Copy Markdown
Contributor

@jbencin jbencin commented Feb 28, 2023

Description

Add a couple lines in .vscode/settings.json so that the Deno VSCode extension works correctly

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@jbencin jbencin marked this pull request as draft February 28, 2023 20:22
@jbencin
Copy link
Copy Markdown
Contributor Author

jbencin commented Feb 28, 2023

Converted to draft... I see that we have at least one NodeJS project in the repo so we may not want to enable Deno for this whole workspace

@jbencin jbencin force-pushed the fix/deno-vscode-extension branch from e2e4d31 to da07d54 Compare March 1, 2023 14:28
@jbencin
Copy link
Copy Markdown
Contributor Author

jbencin commented Mar 1, 2023

Changed to use the config option deno.enablePaths so that the extension is only used for Deno projects and not NodeJS projects

@jbencin jbencin marked this pull request as ready for review March 1, 2023 14:31
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #223 (da07d54) into master (54c653c) will increase coverage by 1.06%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
+ Coverage   91.19%   92.26%   +1.06%     
==========================================
  Files           6        6              
  Lines         284      336      +52     
==========================================
+ Hits          259      310      +51     
- Misses         25       26       +1     
Impacted Files Coverage Δ
core-contracts/contracts/helper/simple-ft.clar 75.00% <ø> (-1.48%) ⬇️
...contracts/contracts/helper/simple-nft-no-mint.clar 66.66% <ø> (ø)
core-contracts/contracts/helper/simple-nft.clar 73.33% <ø> (ø)
core-contracts/contracts/multi-miner.clar 97.05% <ø> (ø)
core-contracts/contracts/subnet.clar 94.96% <ø> (+0.81%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Copy Markdown
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jbencin jbencin merged commit e23b941 into hirosystems:master Mar 1, 2023
@jbencin jbencin deleted the fix/deno-vscode-extension branch March 1, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants