Add some more subnet contract tests#227
Conversation
…hat only token owner can transfer
Codecov Report
@@ Coverage Diff @@
## master #227 +/- ##
===========================================
+ Coverage 0 93.47% +93.47%
===========================================
Files 0 6 +6
Lines 0 337 +337
===========================================
+ Hits 0 315 +315
- Misses 0 22 +22
... and 5 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
obycode
left a comment
There was a problem hiding this comment.
Before I go through all of the details in subnet_test.ts, could you separate out those new assertions into separate tests, so each one is a separate Clarinet.test? This makes quickly reviewing the results of the test much simpler.
core-contracts/README.md
Outdated
| @@ -0,0 +1,21 @@ | |||
| # Subnets Core Contracts | |||
|
|
|||
| Essential Clarity contracts for using Stacks Subnets | |||
There was a problem hiding this comment.
I like the idea of putting a README in here. Let's expand it a bit.
| Essential Clarity contracts for using Stacks Subnets | |
| This directory contains the contracts published to the Stacks L1 to implement a subnet. | |
| * _subnet.clar_: interface between the subnet and the L1 | |
| * _multi-miner.clar_: implements a multi-miner for the subnet | |
| * _helper/*_: used for testing |
There was a problem hiding this comment.
I wasn't sure whether to do this or not because it takes a decent amount of setup to get to the point where I can attempt these transactions, but yeah I can make this change
There was a problem hiding this comment.
Yeah, I think it's worth it, since these tests don't take long to run.
There was a problem hiding this comment.
It was the code duplication that I wanted to avoid. Anyway, I did split most of my new tests out into separate tests. Also fixed all the remaining deno lint warnings in the subnet_test.ts file
Co-authored-by: Brice Dobry <brice@obycode.com>
1664a5a to
409b9be
Compare
|
Go ahead and remove the draft status on this when you're ready for a review. Is it ready now? |
obycode
left a comment
There was a problem hiding this comment.
This is great. Just one minor comment.
Description
Added some failing tests for the
subnet.clarcontract. Some examples include:Applicable issues
Additional info (benefits, drawbacks, caveats)
Checklist
docs/rpc/openapi.yamlandrpc-endpoints.mdfor v2 endpoints,event-dispatcher.mdfor new events)clarity-benchmarkingrepobitcoin-tests.yml