Merged
Conversation
obycode
requested review from
jbencin and
lgalabru
and removed request for
lgalabru
Clarinet now retrieves the contracts from the network, so we do not need the hack of putting them in the image.
Codecov Report
@@ Coverage Diff @@
## master #240 +/- ##
=======================================
Coverage 93.47% 93.47%
=======================================
Files 6 6
Lines 337 337
=======================================
Hits 315 315
Misses 22 22 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jbencin
approved these changes
Mar 16, 2023
Contributor
jbencin
left a comment
jbencin
left a comment
There was a problem hiding this comment.
Looks good. These instructions are working for me using Clarinet commit fa2a2fee
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These instructions work with the version of clarinet from stx-labs/clarinet#937 to resolve the problems launching a devnet subnet.