fix: Return non-zero value for burn_block_time in v1 API#243
Merged
jbencin merged 1 commit intohirosystems:masterfrom Mar 23, 2023
Merged
fix: Return non-zero value for burn_block_time in v1 API#243jbencin merged 1 commit intohirosystems:masterfrom
burn_block_time in v1 API#243jbencin merged 1 commit intohirosystems:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #243 +/- ##
===========================================
+ Coverage 0 93.47% +93.47%
===========================================
Files 0 6 +6
Lines 0 337 +337
===========================================
+ Hits 0 315 +315
- Misses 0 22 +22 see 6 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
2264b75 to
3a5eb33
Compare
…urn non-zero timestamps
3a5eb33 to
61276de
Compare
obycode
approved these changes
Mar 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
API endpoints
extended/v1/blockandextended/v1/blockwere empty/zero values for the following variables:{ "burn_block_time": 0, "burn_block_time_iso": "", "parent_burn_block_time": 0, "parent_burn_block_time_iso": "" }This was due to failing to parse and store the timestamp from the burnchain block in
StacksSubnetBlock::from_new_block_event(). This PR fixes this issue so that these variables are now proper Unix and ISO-8601 timestamps:{ "burn_block_time": 1679512099, "burn_block_time_iso": "2023-03-22T19:08:19.000Z", "parent_burn_block_time": 1679512039, "parent_burn_block_time_iso": "2023-03-22T19:07:19.000Z", }Applicable issues
Additional info (benefits, drawbacks, caveats)
We still report
0for genesis block. Not sure if that's a problemChecklist
docs/rpc/openapi.yamlandrpc-endpoints.mdfor v2 endpoints,event-dispatcher.mdfor new events)clarity-benchmarkingrepobitcoin-tests.yml