Skip to content

Fix: peer versions must end in 0x06#244

Merged
obycode merged 1 commit intomasterfrom
fix/peer-versions
Mar 24, 2023
Merged

Fix: peer versions must end in 0x06#244
obycode merged 1 commit intomasterfrom
fix/peer-versions

Conversation

@kantai
Copy link
Copy Markdown
Contributor

@kantai kantai commented Mar 23, 2023

Description

When Epoch 2.1 rules activate on a subnet, the subnet's net module will ignore peers with peer_versions that have a final byte less than 0x06.

This was causing our deployed subnet follower to be unable to communicate with the deployed leader.

Once this merges, simply restarting the nodes with this change should address the networking issue.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 23, 2023

Codecov Report

Merging #244 (f0dae86) into master (7012d22) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #244   +/-   ##
=======================================
  Coverage   93.47%   93.47%           
=======================================
  Files           6        6           
  Lines         337      337           
=======================================
  Hits          315      315           
  Misses         22       22           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Copy Markdown
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tracking this down @kantai!

@obycode obycode merged commit 1681ed3 into master Mar 24, 2023
@obycode obycode deleted the fix/peer-versions branch March 24, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants