fix: Update reqwest and disable OpenSSL to address CVEs#254
fix: Update reqwest and disable OpenSSL to address CVEs#254jbencin merged 1 commit intohirosystems:masterfrom
reqwest and disable OpenSSL to address CVEs#254Conversation
Codecov Report
@@ Coverage Diff @@
## master #254 +/- ##
=======================================
Coverage 93.47% 93.47%
=======================================
Files 6 6
Lines 337 337
=======================================
Hits 315 315
Misses 22 22 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
obycode
left a comment
There was a problem hiding this comment.
Looks good to me. Have you tried spinning up a devnet with this change to make sure everything still works?
I can do that. Do we actually use TLS anywhere in the node and do you know of any way to specifically test it? Otherwise I'll just start it up with |
I'm not sure, maybe @kantai can help answer that. I think using |
|
Yep -- I think the only place that TLS is used in the node is (optionally) when making L1 RPC requests. This is configured with the I think just testing this out with |
|
Just tested everything with If anyone else wants to try, it's the |
Description
Update
reqwestdependency and remove OpenSSL supportApplicable issues
Additional info (benefits, drawbacks, caveats)
There are a few reasons to prefer Rustls over OpenSSL:
Checklist
docs/rpc/openapi.yamlandrpc-endpoints.mdfor v2 endpoints,event-dispatcher.mdfor new events)clarity-benchmarkingrepobitcoin-tests.yml