Fix: Rename withdrawal_id to withdrawal-id

[jbencin]

Description

Rename withdrawal_id to withdrawal-id, because we should be consistently using kebab-case for Clarity values

Applicable issues

• fixes Use withdrawal-id instead of withdrawal_id in events #245

Additional info (benefits, drawbacks, caveats)

I'm not sure if the following lines in http.rs should be changed also:

HttpRequestType::GetWithdrawalStx { .. } => {
    "/v2/withdrawal/stx/:block-height/:sender/:withdrawal_id/:amount"
}
HttpRequestType::BlockProposal(..) => PATH_STR_POST_BLOCK_PROPOSAL,
HttpRequestType::GetWithdrawalFt { .. } => {
    "/v2/withdrawal/ft/:block-height/:sender/:withdrawal_id/:contract_address/:contract_name/:amount"
}
HttpRequestType::GetWithdrawalNft { .. } => {
    "/v2/withdrawal/nft/:block-height/:sender/:withdrawal_id/:contract_address/:contract_name/:id"
}

I don't understand this syntax and have no idea what it means

Checklist

• Test coverage for new or modified code paths
• Changelog is updated
• Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
• New clarity functions have corresponding PR in clarity-benchmarking repo
• New integration test(s) added to bitcoin-tests.yml

[codecov]

Codecov Report

Merging #255 (6a858cc) into master (a762f8f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #255   +/-   ##
=======================================
  Coverage   93.47%   93.47%           
=======================================
  Files           6        6           
  Lines         337      337           
=======================================
  Hits          315      315           
  Misses         22       22           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[obycode]

lgtm!