Skip to content

Walkthrough guide edits#263

Merged
mefrem merged 7 commits intomasterfrom
mefrem-subnets-guide-v2
Apr 21, 2023
Merged

Walkthrough guide edits#263
mefrem merged 7 commits intomasterfrom
mefrem-subnets-guide-v2

Conversation

@mefrem
Copy link
Copy Markdown
Contributor

@mefrem mefrem commented Apr 21, 2023

Description

Penultimate changes to Getting Started guide before preview announcement to Discord on Friday. Changes pertain mostly to docker tags, also some additional clarifying language.

PR is not complete, needs resolution of $ node ./verify.js 2 bug which returns none instead of expected account, one of the last steps in the guide.

@mefrem mefrem requested a review from jbencin April 21, 2023 03:24
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 21, 2023

Codecov Report

Merging #263 (94e6961) into master (41aac7a) will not change coverage.
The diff coverage is n/a.

❗ Current head 94e6961 differs from pull request most recent head 377e3bc. Consider uploading reports for the commit 377e3bc to get more accurate results

@@           Coverage Diff           @@
##           master     #263   +/-   ##
=======================================
  Coverage   93.49%   93.49%           
=======================================
  Files           6        6           
  Lines         338      338           
=======================================
  Hits          316      316           
  Misses         22       22           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

mefrem added 2 commits April 21, 2023 09:19
Added clarification about subnet block confirmations.
mefrem and others added 4 commits April 21, 2023 10:10
Co-authored-by: jbencin <jeff.bencin@gmail.com>
Co-authored-by: jbencin <jeff.bencin@gmail.com>
Co-authored-by: jbencin <jeff.bencin@gmail.com>
Co-authored-by: jbencin <jeff.bencin@gmail.com>
@mefrem mefrem merged commit c0287d3 into master Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants