New config for Lenovo ThinkPad L390 i7-8565U#685
Merged
hirschmann merged 6 commits intohirschmann:masterfrom Jun 5, 2019
Merged
New config for Lenovo ThinkPad L390 i7-8565U#685hirschmann merged 6 commits intohirschmann:masterfrom
hirschmann merged 6 commits intohirschmann:masterfrom
Conversation
1. This config is based on **Lenovo U41-70.xml** config file, cause of write and reads I think. Any other of ThinkPad lines didn't work for my laptop. 2. Based on **Lenovo U41-70.xml** config. 3. This config doesn't require any modifications - just dropdown -> find it in the list -> Press **Apply** => and it will work. P.S. Added CPU model, cause I thought it can cause different coolers - I don't know for sure.
1. Added to the author field my surname. 2. Changed temperature threshold to start temperatures have matched with system settings (only from 68 degrees fan set to 85%, af after 90 degrees set to 100% - system settings wasn't turn on for full-power).
Owner
|
Thank you very much for your effort.
see: https://ci.appveyor.com/project/hirschmann/nbfc/builds/24547666/tests Please fix this small issue and update the pull request, so I can merge it :) |
1. Set "Poll interval" to 3 sec. 2. Deleted penult temperature threshold (very often temperature changes and fan is noisy) 3. Last temperature threshold's up set to 99 (below of Critical temperature)
Contributor
Author
|
Fixed the issue - can merge the PR |
Owner
|
Thanks for the fix :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accordingly to this guideline for config files, I'm answering by their order:
Changes to base config: