Cosmetic update for config of Gigabyte AERO 14KV8#697
Merged
hirschmann merged 1 commit intohirschmann:masterfrom Jun 5, 2019
Merged
Cosmetic update for config of Gigabyte AERO 14KV8#697hirschmann merged 1 commit intohirschmann:masterfrom
hirschmann merged 1 commit intohirschmann:masterfrom
Conversation
Thank you for the quick merge and the kind words. This is a small cosmetic update for the Gigabyte AERO 14KV8 configuration that you just pulled: - one of the RegisterWriteConfigurations unnecessarily had the write mode set to "OnWriteFanSpeed" even though it is enough to set the respective register once in order to enable the required fan mode. This is now fixed by setting the write mode to "OnInitialization" so that the register is not written all the time without need for it. - for one of the fans the temperature ranges were not listed in ascending order. This is not actually a problem but ascending order is nicer to read so I fixed this as well :-)
Owner
|
Thanks for the update :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for the quick merge and the kind words.
This is a small cosmetic update for the Gigabyte AERO 14KV8 configuration that you just pulled:
Thanks again for your great work and sorry for not catching these things right away
Christian