Fix 'HP ProBook 650 G2' not reaching 0%#775
Merged
hirschmann merged 1 commit intohirschmann:masterfrom Oct 29, 2019
Merged
Conversation
When simply mapping fan register value of 255 to 0%, the fan is not able to reach 0% directly when starting at a rather high speed, running constantly at around 25% instead. This can be worked around manually by first setting the speed to a value between 0% and 20%, then setting it to 0%. Mapping the fan register value of 254 to 0% fixes the issue permanently. Mapping read value of 255 to 0% fixes the percentage indicator which shows negative speed values otherwise.
Owner
|
Thanks a lot for the fix! Looks good to me. |
vdurante
pushed a commit
to vdurante/nbfc
that referenced
this pull request
Feb 29, 2024
When simply mapping fan register value of 255 to 0%, the fan is not able to reach 0% directly when starting at a rather high speed, running constantly at around 25% instead. This can be worked around manually by first setting the speed to a value between 0% and 20%, then setting it to 0%. Mapping the fan register value of 254 to 0% fixes the issue permanently. Mapping read value of 255 to 0% fixes the percentage indicator which shows negative speed values otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When simply mapping fan register value of 255 to 0%, the fan is not able
to reach 0% directly when starting at a rather high speed, running
constantly at around 25% instead. This can be worked around manually by
first setting the speed to a value between 0% and 20%, then setting it
to 0%.
Mapping the fan register value of 254 to 0% fixes the issue permanently.
Mapping read value of 255 to 0% fixes the percentage indicator which
shows negative speed values otherwise.