Skip to content

may I suggest a test and a bit of a clean-up#2

Merged
hmallen merged 7 commits intohmallen:masterfrom
volodymyrss:master
Oct 5, 2020
Merged

may I suggest a test and a bit of a clean-up#2
hmallen merged 7 commits intohmallen:masterfrom
volodymyrss:master

Conversation

@volodymyrss
Copy link
Contributor

I find myself repeating this piece of code, so it was good to find a module, thanks a lot!

@hmallen
Copy link
Owner

hmallen commented Aug 13, 2020

This is very helpful, I sincerely appreciate the pull request. I was having the same issue with reusing this code which is why I packaged it up for PyPI. Despite using code quite extensively in my work at this point, I have neither a formal education in computer science nor experience in a professional development setting, so unit testing and industry best practices are things that I've been integrating as I progress. I'll review and merge to bring this into a more production ready state. Thanks again.

@hmallen hmallen merged commit f9f65a3 into hmallen:master Oct 5, 2020
hmallen added a commit that referenced this pull request May 21, 2025
may I suggest a test and a bit of a clean-up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants