Removes appinsights module from java-logging #639
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tools.hmcts.net/jira/browse/DTSPO-24922
AppInsights 2.x is no longer in support
We had it defaulted to this version in java-logging.
Teams got around this in a few ways:
App Insights agent is added into base images for java
We have no use of 2.x SDK anymore even though it's defined in this module as a hard dependency, meaning Dockerfile override or non-use.
Suggestion is that we publish a new
7.0.0version of java-logging which removes thelogging-appinsights- so when teams upgrade they can remove the dependency line i.e. removingThis change coupled with major version upgrade should remove confusion about 2.x SDK and remove any risk that we're still using it anywhere