Skip to content

HMA-10992 added mtd enrolment check #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pdhiman3006 merged 2 commits into from
Dec 9, 2025
Merged

HMA-10992 added mtd enrolment check #172

pdhiman3006 merged 2 commits into from
Dec 9, 2025

Conversation

@pdhiman3006
Copy link
Contributor

@pdhiman3006 pdhiman3006 commented Dec 8, 2025

No description provided.

@platops-pr-bot
Copy link

platops-pr-bot commented Dec 8, 2025

  • You have multiple routes files conf/app.routes, conf/sandbox.routes using the same package uk.gov.hmrc.mobilestartup.controllers, which leads to collision with the reverse routes. Please ensure each routes file refers to a different package.

JavedBeg-ac
JavedBeg-ac reviewed Dec 9, 2025
View reviewed changes
test/uk/gov/hmrc/mobilestartup/services/LivePreFlightServiceSpec.scala
.returning(response)

"getUTR" should {
"return some utr if only IR-SA enroll,ment is there" in {
Copy link
Contributor

@JavedBeg-ac JavedBeg-ac Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is one typo

JavedBeg-ac
JavedBeg-ac reviewed Dec 9, 2025
View reviewed changes
test/uk/gov/hmrc/mobilestartup/services/LivePreFlightServiceSpec.scala Outdated
await(result) shouldBe (Some(Utr(Some(saUtr), Activated, None)))
}

"return some utr if only MTD enrollment is there and utyr is also there" in {
Copy link
Contributor

@JavedBeg-ac JavedBeg-ac Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utyr - typo

Copy link
Contributor Author

@pdhiman3006 pdhiman3006 Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@pdhiman3006 pdhiman3006 merged commit 17b1aec into main Dec 9, 2025
1 check passed
@pdhiman3006 pdhiman3006 deleted the HMA-10992 branch December 9, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JavedBeg-ac JavedBeg-ac JavedBeg-ac approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pdhiman3006 @platops-pr-bot @JavedBeg-ac