Skip to content

Comments

docs(advocacy): add experience in LinkedIn & mention Holdex in X#63

Merged
zolotokrylin merged 1 commit intoholdex:mainfrom
tiffmyaaw:advocacy
Nov 23, 2025
Merged

docs(advocacy): add experience in LinkedIn & mention Holdex in X#63
zolotokrylin merged 1 commit intoholdex:mainfrom
tiffmyaaw:advocacy

Conversation

@tiffmyaaw
Copy link
Contributor

@tiffmyaaw tiffmyaaw commented Nov 21, 2025

fix https://github.com/holdex/ops/issues/66

Summary by CodeRabbit

Documentation

  • Updated advocacy guidelines with new mandatory requirements for professional social media profiles
  • Added mandatory Experience description to LinkedIn profile section with organizational information
  • Expanded X (Twitter) profile requirements including mandatory role identification, website portfolio link, and location field

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 21, 2025

Walkthrough

Documentation update to advocacy guidelines file establishing mandatory profile requirements. Additions include required Experience description about Holdex for LinkedIn profiles and expanded X (Twitter) profile requirements specifying role mention, website link, and location field settings.

Changes

Cohort / File(s) Change Summary
Documentation Updates
\.github/ADVOCACY\.md
Added mandatory Experience description under LinkedIn profile section with Holdex descriptive paragraph. Expanded X (Twitter) Profile section with new requirements: role @HoldexIo mention in profile description, Holdex website/portfolio link, and Location field set to localhost.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single file modification containing documentation/guideline updates only
  • No code logic changes or functional alterations
  • Straightforward additions to existing profile requirements

Suggested reviewers

  • dante4rt

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed The PR addresses the linked issue #66 by updating the Advocating Guidelines with new LinkedIn profile requirements including Experience descriptions and X/Twitter profile mandatory fields.
Out of Scope Changes check ✅ Passed All changes are within scope—the PR only modifies .github/ADVOCACY.md to add LinkedIn and X profile requirements as specified in the linked issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately describes the main changes: adding an experience description for LinkedIn and requiring Holdex mention in X profile, which aligns with the file modifications in ADVOCACY.md.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tiffmyaaw
Copy link
Contributor Author

@zolotokrylin I couldn't add you as reviewer and myself as the assignee

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
.github/ADVOCACY.md (2)

48-49: Minor: Article and styling adjustments for LinkedIn Experience description.

Line 49 reads "Holdex is premier partner..." but should be "Holdex is a premier partner..." for grammatical correctness.

Additionally, Line 48 uses backticks around Mandatory, but the document style elsewhere uses bold formatting. Consider using **Mandatory** for consistency or plain text if it's meant to be unemphasized.

-Mandatory `Experience` description:
-> Holdex is premier partner for institutions pioneering DeFi & RWAs. Hong Kong-based since 2016, we turn bold visions into secure, scalable blockchain solutions – driving adoption with unmatched expertise.
+**Mandatory** Experience description:
+> Holdex is **a** premier partner for institutions pioneering DeFi & RWAs. Hong Kong-based since 2016, we turn bold visions into secure, scalable blockchain solutions – driving adoption with unmatched expertise.

51-55: Formatting inconsistency: X (Twitter) requirements lack table structure used elsewhere.

The GitHub profile requirements (lines 29–41) use a clear table format for acceptance criteria, while the X (Twitter) profile requirements (lines 53–55) use bullet points. For better readability and consistency, consider adopting a table format or moving these into the existing structure.

This is a minor UX/readability concern and can be deferred if the current format is preferred.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c854427 and 0e84859.

📒 Files selected for processing (1)
  • .github/ADVOCACY.md (1 hunks)

@holdex
Copy link

holdex bot commented Nov 21, 2025

Time Submission Status

Member Status Time Action Last Update
tiffmyaaw ✅ Submitted 30min Update time Nov 23, 2025, 11:12 AM
zolotokrylin ✅ Submitted 15min Update time Nov 23, 2025, 11:12 AM

Copy link
Member

@zolotokrylin zolotokrylin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong naming of the PR

@tiffmyaaw tiffmyaaw changed the title docs: update Advocating Guidelines docs: clarify advocating guidelines for contributors Nov 22, 2025
@tiffmyaaw tiffmyaaw changed the title docs: clarify advocating guidelines for contributors docs: clarify advocacy guidelines for contributors Nov 22, 2025
@tiffmyaaw
Copy link
Contributor Author

@zolotokrylin revised

@zolotokrylin
Copy link
Member

@tiffmyaaw, this is not how we request reviews. See the guidelines.
cc: @markholdex

@zolotokrylin
Copy link
Member

Your naming isn’t right. It should be user-oriented, as per our guidelines. I would reject your request again, but you didn’t request a review from me since the time I rejected it.

@tiffmyaaw
Copy link
Contributor Author

Your naming isn’t right. It should be user-oriented, as per our guidelines. I would reject your request again, but you didn’t request a review from me since the time I rejected it.

@zolotokrylin I couldn't tag you as a reviewer, I don't have access for it. Or do you mean tagging like this within the comment?

@tiffmyaaw tiffmyaaw changed the title docs: clarify advocacy guidelines for contributors docs: view advocacy guidelines for contributors Nov 23, 2025
@zolotokrylin
Copy link
Member

@tiffmyaaw
image

@zolotokrylin zolotokrylin changed the title docs: view advocacy guidelines for contributors docs(advocacy): add experience in LinkedIn & mention Holdex in X Nov 23, 2025
@zolotokrylin zolotokrylin merged commit a8360d3 into holdex:main Nov 23, 2025
3 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Nov 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants