docs(advocacy): add experience in LinkedIn & mention Holdex in X#63
docs(advocacy): add experience in LinkedIn & mention Holdex in X#63zolotokrylin merged 1 commit intoholdex:mainfrom
Conversation
WalkthroughDocumentation update to advocacy guidelines file establishing mandatory profile requirements. Additions include required Experience description about Holdex for LinkedIn profiles and expanded X (Twitter) profile requirements specifying role mention, website link, and location field settings. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@zolotokrylin I couldn't add you as reviewer and myself as the assignee |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/ADVOCACY.md (2)
48-49: Minor: Article and styling adjustments for LinkedIn Experience description.Line 49 reads "Holdex is premier partner..." but should be "Holdex is a premier partner..." for grammatical correctness.
Additionally, Line 48 uses backticks around
Mandatory, but the document style elsewhere uses bold formatting. Consider using**Mandatory**for consistency or plain text if it's meant to be unemphasized.-Mandatory `Experience` description: -> Holdex is premier partner for institutions pioneering DeFi & RWAs. Hong Kong-based since 2016, we turn bold visions into secure, scalable blockchain solutions – driving adoption with unmatched expertise. +**Mandatory** Experience description: +> Holdex is **a** premier partner for institutions pioneering DeFi & RWAs. Hong Kong-based since 2016, we turn bold visions into secure, scalable blockchain solutions – driving adoption with unmatched expertise.
51-55: Formatting inconsistency: X (Twitter) requirements lack table structure used elsewhere.The GitHub profile requirements (lines 29–41) use a clear table format for acceptance criteria, while the X (Twitter) profile requirements (lines 53–55) use bullet points. For better readability and consistency, consider adopting a table format or moving these into the existing structure.
This is a minor UX/readability concern and can be deferred if the current format is preferred.
Time Submission Status
|
|
@zolotokrylin revised |
|
@tiffmyaaw, this is not how we request reviews. See the guidelines. |
|
Your naming isn’t right. It should be user-oriented, as per our guidelines. I would reject your request again, but you didn’t request a review from me since the time I rejected it. |
@zolotokrylin I couldn't tag you as a reviewer, I don't have access for it. Or do you mean tagging like this within the comment? |

fix https://github.com/holdex/ops/issues/66
Summary by CodeRabbit
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.