Draft
Conversation
21fc3d6 to
cf6a004
Compare
be7d04d to
9f47065
Compare
…tOffset, elementAtOffset, scopeAtOffset, scopeKindAtOffset)
…queries to use project-wide API, wire flatStream/invalidStream/symbol queries
…okens, add getSource
…rs/warnings global queries
9f47065 to
51aea0e
Compare
b8d068e to
7a621c4
Compare
…Index, add FileLocalSymbolIndex
…alidator/, split pipeline into validate.ts and resolve.ts
…Project delegates to localSymbolTable
…for cross-file resolution
…r requires it from callers
…ccepts or requires it from callers" This reverts commit b5d7d20.
…le as thin query returning just the symbol table
…ve unused symbolTable from ExternalSymbol
…, Filepath; replace FilepathKey with FilepathId; remove toKey from globalQuery
…directly from validateFile instead of Report
…gnore external file validation errors in resolve
…-file queries only
9144c7c to
877828f
Compare
877828f to
bea0d06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue
(issue link here)
Lasting Changes (Technical)
(please list down: code changes/things that have wide-effect; new libraries/functions added that can be used by others; examples below)
class EmailValidatorto validate email address' validity)Tenant#is_trial?check)Checklist
Please check directly on the box once each of these are done