Send IP address of Matter device for on network commissioning#4069
Merged
JBassett merged 3 commits intohome-assistant:masterfrom Jan 4, 2024
Merged
Conversation
972559e to
54672be
Compare
agners
approved these changes
Jan 3, 2024
JBassett
approved these changes
Jan 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Requires: home-assistant/core#106237
When using
matter/commission_on_network(commissioning started from the frontend), also send the IP address returned by the system to the server in order to fix matter-js/python-matter-server#463. Read the issue + linked PR for more details.The websocket message will now look like this:
Screenshots
n/a
Link to pull request in Documentation repository
n/a
Any other notes