Skip to content

Conversation

@TimoPtr
Copy link
Member

@TimoPtr TimoPtr commented Jan 2, 2026

Summary

While adding multiple server I found out that the LocationForSecureConnection was not shown during the onboarding of a second server instead I was seeing the ConnectionSecurityLevelFragment with the cross. It was making the selection of the option optional that we don't want.

It is due to an early logic that I left in the graph, I wanted to automatically pick Most secure when the user was enabling location tracking, but we never set this. While it was a nice idea I think it might still be best to show the option picker, to let the user understand.

This also had an impact on the minimal flavor since there was no location tracking screen at all, it was only checking if the location permission was given if yes then it was skip and the fragment was shown.

This PR is not going to have a huge impact on the users, but simply making sure that the navigation graph is coherent.

Checklist

  • New or updated tests have been added to cover the changes following the testing guidelines.
  • The code follows the project's code style and best_practices.
  • The changes have been thoroughly tested, and edge cases have been considered.
  • Changes are backward compatible whenever feasible. Any breaking changes are documented in the changelog for users and/or in the code for developers depending on the relevance.

@TimoPtr TimoPtr requested a review from jpelgrom January 2, 2026 15:18
Copy link
Member

@jpelgrom jpelgrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may not have a big impact, but any changes to this graph make me triple check everything 😵‍💫.

In the end it does make things simpler and more coherent, and onboarding doesn't happen that frequently so nice change!

…ing/OnboardingNavigation.kt

Co-authored-by: Joris Pelgröm <jpelgrom@users.noreply.github.com>
@TimoPtr TimoPtr enabled auto-merge (squash) January 7, 2026 17:26
@TimoPtr TimoPtr merged commit 506b327 into main Jan 7, 2026
22 checks passed
@TimoPtr TimoPtr deleted the fix/location_for_secure_connection_nav_graph branch January 7, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants