Always show LocationForSecureConnection when using HTTP while onboarding #6223
+33
−97
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While adding multiple server I found out that the
LocationForSecureConnectionwas not shown during the onboarding of a second server instead I was seeing theConnectionSecurityLevelFragmentwith the cross. It was making the selection of the option optional that we don't want.It is due to an early logic that I left in the graph, I wanted to automatically pick
Most securewhen the user was enabling location tracking, but we never set this. While it was a nice idea I think it might still be best to show the option picker, to let the user understand.This also had an impact on the minimal flavor since there was no location tracking screen at all, it was only checking if the location permission was given if yes then it was skip and the fragment was shown.
This PR is not going to have a huge impact on the users, but simply making sure that the navigation graph is coherent.
Checklist