Skip to content

Conversation

@epenet
Copy link
Contributor

@epenet epenet commented May 23, 2023

Proposed change

https://github.com/encode/httpx/releases/tag/0.24.1

In particular encode/httpx#2701

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@epenet epenet requested a review from a team as a code owner May 23, 2023 10:06
@home-assistant home-assistant bot added bugfix cla-signed core small-pr PRs with less than 30 lines. labels May 23, 2023
@epenet epenet added this to the 2023.5.4 milestone May 23, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @epenet 👍

../Frenck

frenck
frenck previously requested changes May 23, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A merge conflict has occurred, could you take a look, @epenet? 👍

../Frenck

@home-assistant home-assistant bot marked this pull request as draft May 23, 2023 13:06
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@epenet epenet marked this pull request as ready for review May 23, 2023 13:08
@home-assistant home-assistant bot requested a review from frenck May 23, 2023 13:08
@bdraco bdraco dismissed frenck’s stale review May 23, 2023 17:08

merge conflict fixed

@bdraco
Copy link
Member

bdraco commented May 23, 2023

Thanks @epenet

@bdraco bdraco merged commit 160fce7 into home-assistant:dev May 23, 2023
@epenet epenet deleted the httpx branch May 23, 2023 17:31
@bdraco
Copy link
Member

bdraco commented May 23, 2023

Also, I tested this on two production installs

frenck pushed a commit that referenced this pull request May 23, 2023
@frenck frenck mentioned this pull request May 23, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parsing XML with Rest Sensor broken

3 participants