remove undefined variable of LLAMAINDEX_INSTALLED#155
Open
yujinlim wants to merge 1 commit intohoneyhiveai:mainfrom
Open
remove undefined variable of LLAMAINDEX_INSTALLED#155yujinlim wants to merge 1 commit intohoneyhiveai:mainfrom
yujinlim wants to merge 1 commit intohoneyhiveai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue is that
LLAMAINDEX_INSTALLEDis not defined. Since that it was primarily set to check if there is llamaindex package installed based on c1ccddb#diff-a75e354e6c693b88e3727ae20d945c6fe87a45c42fee4ea0fa5b565f7bc22d98R58 and there already a lazy import checker here c1ccddb#diff-a75e354e6c693b88e3727ae20d945c6fe87a45c42fee4ea0fa5b565f7bc22d98R21 . We can safely remove this broken variable.