fix: ensure close handler is attached for Blob/ReadableStream cacheable responses#342
Merged
fix: ensure close handler is attached for Blob/ReadableStream cacheable responses#342
Conversation
Member
Author
|
Hi @yusukebe |
Member
|
Thanks! This should be fixed. Looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous fast-path check (introduced in #333) (
cacheKey in res) did not distinguish body types, allowingBlobandReadableStreamresponses to skip close handler registration. This meant client disconnects during async body processing would not triggerAbortSignal.Restrict the fast path to body types that complete synchronously (null, string, Uint8Array) via
isImmediateCacheableResponse. All other cacheable responses now go throughensureCloseHandlerfor proper abort detection.