Open
Conversation
horoshev
reviewed
Mar 18, 2022
| order.UserId = userId | ||
| order.Status = models.OrderPending | ||
| order.Timestamp = time.Now().UTC() | ||
| order.Timestamp = time.Now().UTC() // Здесь есть некоторая проблема. Можешь порассуждать? |
Owner
There was a problem hiding this comment.
Не совсем очевидно.
Думаю проблема в том, что потом для пользователя надо будет преобразовывать значение к его временной зоне.
И возможно здесь Timestamp не отражает, что он в UTC и лучше было бы использовать название TimestampUTC.
horoshev
reviewed
Mar 18, 2022
| return identity, nil | ||
| } | ||
|
|
||
| // А можешь пояснить, зачем столько вариантов? |
Owner
There was a problem hiding this comment.
Для GET запросов неполучится из тела запроса uid получить, и я добавил для параметров.
Для swagger добавил куку, чтобы не вводить каждый раз uid и забыл убрать.
Для контекста нужно выше поднять, чтобы лишний раз не вытаскивать из запроса.
horoshev
reviewed
Mar 18, 2022
| UpdateOrder(id primitive.ObjectID, updates []bson.E) (*models.Order, error) | ||
| UpdateOrderStatus(id primitive.ObjectID, status models.OrderStatus) (*models.Order, error) | ||
| Commit() error | ||
| Commit() error // Искал, куда ты хотел вставить этот метод, но не нашёл в коде) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.