Open
Conversation
In a semi-recent change to devmem2, the output of the tool was changed from "Value at address..." to "Read at address". The relevant commit to devmem2: VCTLabs/devmem2@5a438ff To allow the script to still parse the line correctly, a small regex change is necessary. Now, the script supports both versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a semi-recent (1.5 years) change to the github version of devmem2, the output of the tool was changed from
"Value at address..."to"Read at address". This is the relevant commit to devmem2: VCTLabs/devmem2@5a438ffThis results in failure to read from devmem2 and the MMIO.
To allow the script to still parse the line correctly, a small regex change is necessary. Now, the script supports both versions of devmem2.