Skip to content
This repository was archived by the owner on Aug 21, 2025. It is now read-only.

Add Geocode endpoint and allow extra identifiers in command line tools#26

Open
j-francisco wants to merge 6 commits into
masterfrom
geocode-endpoint
Open

Add Geocode endpoint and allow extra identifiers in command line tools#26
j-francisco wants to merge 6 commits into
masterfrom
geocode-endpoint

Conversation

@j-francisco
Copy link
Copy Markdown
Contributor

@travisjungroth
Copy link
Copy Markdown
Contributor

Is this predicated on geocode working in componenet_met?

@j-francisco
Copy link
Copy Markdown
Contributor Author

Sort of. You'll get the error if you make a component_mget request that includes geocode as a component. You can use hc_api_export with only property/geocode and it will work, but if you include it with others (or if you use property/*) then you'll get the error.

@travisjungroth
Copy link
Copy Markdown
Contributor

Okay, that won't block us from pulling it into master but we should wait on pushing to pypi. I'm going to bug those guys about it then review this more.

Copy link
Copy Markdown
Contributor

@travisjungroth travisjungroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but waiting on analytics api bugfix before pypi release.

@kirktarou
Copy link
Copy Markdown

Any update?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants