Skip to content

[BUG]: A bug in search_chunk_configuration method of gemini #4052

@Fridge003

Description

@Fridge003

🐛 Describe the bug

At line 160 of colossalai/zero/gemini/chunk/search_utils.py, inside method search_chunk_configuration, size_list is initialized using numel() of params. Then it's taken as the value of size_dict at line 168.
截屏2023-06-21 12 14 06

However, at line 175, the elements of size_list is compared with max_size, a variable with byte as its unit.
截屏2023-06-21 12 17 22

So I think at line 160, a factor of element_size should be multiplied when initializing size_list.

Environment

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions