Skip to content

[NFC] polish colossalai/nn/layer/parallel_1d/layers.py code style #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
binmakeswell merged 1 commit into from
Jul 13, 2022
Merged

[NFC] polish colossalai/nn/layer/parallel_1d/layers.py code style #1290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions colossalai/nn/layer/parallel_1d/layers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,6 @@ def __init__(self,
set_parallel_input(False)
env.vocab_parallel = False


def reset_parameters(self, weight_initializer, bias_initializer) -> None:
fan_in, fan_out = self.in_features, self.num_classes
if self.has_weight:
Expand Down Expand Up @@ -450,7 +449,6 @@ def __init__(self,
is_parallel_output = not self.gather_output
set_parallel_input(is_parallel_output)


def reset_parameters(self, weight_initializer, bias_initializer) -> None:
fan_in, fan_out = self.in_features, self.out_features
weight_initializer(self.weight, fan_in=fan_in, fan_out=fan_out)
Expand Down Expand Up @@ -589,7 +587,6 @@ def __init__(self,
self._set_tensor_parallel_attributes()
set_parallel_input(False)


def reset_parameters(self, weight_initializer, bias_initializer) -> None:
fan_in, fan_out = self.in_features, self.out_features
weight_initializer(self.weight, fan_in=fan_in, fan_out=fan_out)
Expand Down