Skip to content

[hotfix] remove potiential circle import#1307

Merged
FrankLeeeee merged 9 commits intohpcaitech:mainfrom
feifeibear:moe/import
Jul 14, 2022
Merged

[hotfix] remove potiential circle import#1307
FrankLeeeee merged 9 commits intohpcaitech:mainfrom
feifeibear:moe/import

Conversation

@feifeibear
Copy link
Copy Markdown
Contributor

@feifeibear feifeibear commented Jul 14, 2022

fix #1206

@feifeibear
Copy link
Copy Markdown
Contributor Author

feifeibear commented Jul 14, 2022

circle import
nn.moe -> zero -> engine -> zero

now
nn.moe -> zero -> gemini <- engine

@feifeibear feifeibear requested review from FrankLeeeee and ver217 July 14, 2022 05:40
@FrankLeeeee FrankLeeeee merged commit 4165eab into hpcaitech:main Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ver217 ver217 Awaiting requested review from ver217

1 more reviewer

@FrankLeeeee FrankLeeeee FrankLeeeee approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Possible circular import from ShardedModelV2

2 participants

@feifeibear @FrankLeeeee