[fx] fix the false interpretation of algorithm 3 in https://arxiv.org/abs/1604.06174.#1446
Merged
FrankLeeeee merged 16 commits intohpcaitech:mainfrom Aug 12, 2022
super-dainiu:feature/fx_ckpt_chen
Merged
[fx] fix the false interpretation of algorithm 3 in https://arxiv.org/abs/1604.06174.#1446FrankLeeeee merged 16 commits intohpcaitech:mainfrom super-dainiu:feature/fx_ckpt_chen
FrankLeeeee merged 16 commits intohpcaitech:mainfrom
super-dainiu:feature/fx_ckpt_chen
Conversation
…on checkpointing usages
…on checkpointing usages
…on checkpointing usages
…u/ColossalAI into feature/fx_ckpt_chen
FrankLeeeee
reviewed
Aug 12, 2022
FrankLeeeee
approved these changes
Aug 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new?
After a discussion with my collaborator @Cypher30, I figured out my misinterpretation of algorithm 3 in https://arxiv.org/abs/1604.06174. This PR can be viewed as an amendment to this previous PR #1433. Now users don't need to give a specific budget, the budget is automatically estimated through grid search.