Skip to content

[fx] fix the false interpretation of algorithm 3 in https://arxiv.org/abs/1604.06174.#1446

Merged
FrankLeeeee merged 16 commits intohpcaitech:mainfrom
super-dainiu:feature/fx_ckpt_chen
Aug 12, 2022
Merged

[fx] fix the false interpretation of algorithm 3 in https://arxiv.org/abs/1604.06174.#1446
FrankLeeeee merged 16 commits intohpcaitech:mainfrom
super-dainiu:feature/fx_ckpt_chen

Conversation

@super-dainiu
Copy link
Copy Markdown
Contributor

What's new?

After a discussion with my collaborator @Cypher30, I figured out my misinterpretation of algorithm 3 in https://arxiv.org/abs/1604.06174. This PR can be viewed as an amendment to this previous PR #1433. Now users don't need to give a specific budget, the budget is automatically estimated through grid search.

model = resnet18()
input_sample = torch.rand(4, 3, 224, 224)
gm = symbolic_trace(model)
MetaInfoProp(gm).run(input_sample)
gm = chen_greedy(gm)

Comment thread colossalai/fx/passes/algorithms/ckpt_solver_chen.py Outdated
Copy link
Copy Markdown
Contributor

@Cypher30 Cypher30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants