[autoparallel] modify comm nodes' memory cost in construct chain#2263
Merged
Cypher30 merged 4 commits intohpcaitech:debug/ckpt-autoparallelfrom Jan 3, 2023
Merged
Conversation
…tion checkpoint pipeline
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's New?
In this PR, I modify the calculation of the communication node
runtime_applyandruntime_comm_spec_applyin_construct_chainof the auto activation checkpoint solver. The results seem lovely.I also change the compute cost into
fwd_timeandbwd_timeas those two keys inNode.metaare more compatible with communication cost (it is a float after aligning with computational cost).