Skip to content

[hotfix] add norm clearing for the overflow step #2416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1SAA merged 1 commit into from
Jan 10, 2023
Merged

[hotfix] add norm clearing for the overflow step #2416

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions colossalai/nn/optimizer/zero_optimizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,10 @@ def _check_overflow(self):

return self._found_overflow.item() > 0

def _clear_global_norm(self) -> None:
for c16 in self.chunk16_set:
c16.l2_norm = None

def _calc_global_norm(self) -> float:
norm_sqr: float = 0.0
group_to_norm = dict()
Expand Down Expand Up @@ -201,6 +205,7 @@ def step(self, *args, **kwargs):
self.optim_state = OptimState.UNSCALED # no need to unscale grad
self.grad_scaler.update(found_inf) # update gradient scaler
self._logger.info(f'Found overflow. Skip step')
self._clear_global_norm() # clear recorded norm
self.zero_grad() # reset all gradients
self._update_fp16_params()
return
Expand Down