Skip to content

[workflow] fixed example check workflow#2554

Merged
FrankLeeeee merged 2 commits intomainfrom
hotfix/scheduled-workflow
Feb 6, 2023
Merged

[workflow] fixed example check workflow#2554
FrankLeeeee merged 2 commits intomainfrom
hotfix/scheduled-workflow

Conversation

@FrankLeeeee
Copy link
Copy Markdown
Contributor

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

Fixed #2553

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

This PR does 2 things:

  1. fixed the matrix strategy such that other jobs will not stopped if any job fails
  2. separate the workflow to three yaml files corresponding to different event trigger for better readability and maintenability
  3. updated readme to categorize the workflows based on functionality

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 3, 2023

Your pre-commit check failed, follow the steps to run pre-commit on your file for code style consistency.

  1. install pre-commit via "pip install pre-commit"
  2. install pre-commit hooks via "pre-commit install"
  3. run pre-commit on file with format error via "pre-commit run --files path" by replacing "path" with the actual file path
  4. commit and push to your branch

View your job at https://github.com/hpcaitech/ColossalAI/actions/runs/4080580211.
Read our "CONTRIBUTING.md" for more reference to the code style.

@FrankLeeeee FrankLeeeee added bug Something isn't working example example-related issuer or pull request labels Feb 3, 2023
@FrankLeeeee FrankLeeeee merged commit ba47517 into main Feb 6, 2023
@FrankLeeeee FrankLeeeee deleted the hotfix/scheduled-workflow branch February 6, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working DevOps example example-related issuer or pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[devops] example check scheduled workflow fails

1 participant