[setup] fixed inconsistent version meta#2578
Merged
FrankLeeeee merged 1 commit intohpcaitech:mainfrom Feb 6, 2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Checklist before creating the PR
[doc/gemini/tensor/...]: A concise description🚨 Issue number
Fixed #2570
📝 What does this PR do?
The root cause of the issue #2570 is that the
setup.pywill set version to be something like0.2.0+cu11.3+torch1.12if built with CUDA_EXT=1 while the package uploaded has meta data0.2.0when doingpythjon setup.py sdist build. This inconsistency will lead to failure on the pypi side.This PR remove the torch/cuda suffix from the version number, instead, the cuda/torch version used in pre-build will be kept in
colossalai.version.cudaandcolossalai.version.torch.This has been tested on test-pypi successfully.
💥 Checklist before requesting a review
⭐️ Do you enjoy contributing to Colossal-AI?
Tell us more if you don't enjoy contributing to Colossal-AI.