Skip to content

[setup] fixed inconsistent version meta#2578

Merged
FrankLeeeee merged 1 commit intohpcaitech:mainfrom
FrankLeeeee:hotfix/installation
Feb 6, 2023
Merged

[setup] fixed inconsistent version meta#2578
FrankLeeeee merged 1 commit intohpcaitech:mainfrom
FrankLeeeee:hotfix/installation

Conversation

@FrankLeeeee
Copy link
Copy Markdown
Contributor

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

Fixed #2570

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

The root cause of the issue #2570 is that the setup.py will set version to be something like 0.2.0+cu11.3+torch1.12 if built with CUDA_EXT=1 while the package uploaded has meta data 0.2.0 when doing pythjon setup.py sdist build. This inconsistency will lead to failure on the pypi side.

This PR remove the torch/cuda suffix from the version number, instead, the cuda/torch version used in pre-build will be kept in colossalai.version.cuda and colossalai.version.torch.

This has been tested on test-pypi successfully.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@FrankLeeeee FrankLeeeee added the bug Something isn't working label Feb 6, 2023
@FrankLeeeee FrankLeeeee merged commit fba0874 into hpcaitech:main Feb 6, 2023
@FrankLeeeee FrankLeeeee deleted the hotfix/installation branch February 6, 2023 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: pip install failed when CUDA_EXT is 1

1 participant