Skip to content

[workflow] fixed the post-commit failure when no formatting needed#3020

Merged
FrankLeeeee merged 4 commits intohpcaitech:mainfrom
FrankLeeeee:hotfix/post-commit-ci
Mar 7, 2023
Merged

[workflow] fixed the post-commit failure when no formatting needed#3020
FrankLeeeee merged 4 commits intohpcaitech:mainfrom
FrankLeeeee:hotfix/post-commit-ci

Conversation

@FrankLeeeee
Copy link
Copy Markdown
Contributor

@FrankLeeeee FrankLeeeee commented Mar 6, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

Fixed #3021

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

This PR fixed the post-commit workflow such that it is still seen as successful if all files are well-formatted and there is nothing to commit. Have tested the new workflow file in https://github.com/hpcaitech/ColossalAI/actions/runs/4344828018.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@FrankLeeeee FrankLeeeee self-assigned this Mar 6, 2023
@FrankLeeeee FrankLeeeee merged commit 2cd6ba3 into hpcaitech:main Mar 7, 2023
@FrankLeeeee FrankLeeeee deleted the hotfix/post-commit-ci branch March 7, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Post-commit workflow will give the PR an error status even if nothing is wrong

2 participants